Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-9536: Fix scrolling by wheel to scroll smoothly #1611

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vJIYEv
Copy link
Contributor

@vJIYEv vJIYEv commented May 16, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Scroller and VirtualList should show smooth scrolling by wheel with animation but I found scrolling by wheel shows not smooth like before.

Resolution

In scroll handler function, we have code to scroll smoothly with animation.
It runs when 'delta' value is not 0 but 'delta' is 0 now if a scroller is scrolled by wheel.
So I set 'delta' value as the delta of scroll event to show animation.

Additional Considerations

Links

WRQ-9536

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.51%. Comparing base (d2d4a7f) to head (09f7efa).

Files Patch % Lines
useScroll/useEvent.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1611   +/-   ##
========================================
  Coverage    81.51%   81.51%           
========================================
  Files          148      148           
  Lines         6631     6631           
  Branches      1957     1957           
========================================
  Hits          5405     5405           
  Misses         933      933           
  Partials       293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant