Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

[Feature Request] Image pull secrets #52

Closed
ConstBur opened this issue Jun 19, 2022 · 4 comments
Closed

[Feature Request] Image pull secrets #52

ConstBur opened this issue Jun 19, 2022 · 4 comments

Comments

@ConstBur
Copy link

ConstBur commented Jun 19, 2022

Hello,
I built a custom KeyDB image that I would like to pull from my private GitHub registry, so I'd need to indicate an image pull secret (https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry).
Adding it like this to the values yaml didn't work:

...
image: eqalpha/keydb:x86_64_v6.3.1
imagePullSecrets: 
  - regcred
imagePullPolicy: IfNotPresent
...

Would it be possible to add a prop to pass through imagePullSecrets?

@xxated
Copy link

xxated commented Jun 20, 2022

Same issue here. Any updates?

@Antiarchitect
Copy link
Contributor

Antiarchitect commented Jun 27, 2022

Hi guys was off due to vacations.
Please take a look at 0.40.1 and read 0.40.1 Upgrade notice of the keydb chart's README carefully due to (minor) backward incompatible changes.
Please report if any issues.

@ConstBur
Copy link
Author

Hey @Antiarchitect, just upgraded and it worked like a charm! Спасибо! 😃

@Antiarchitect
Copy link
Contributor

@ConstBur With love! Пожалуйста!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants