Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocator #1428

Open
platten opened this issue Feb 21, 2022 · 12 comments
Open

Allocator #1428

platten opened this issue Feb 21, 2022 · 12 comments
Assignees

Comments

@platten
Copy link
Contributor

platten commented Feb 21, 2022

No description provided.

@jarkkojs
Copy link
Contributor

What is "allocator"? @npmccallum @haraldh

@haraldh
Copy link
Member

haraldh commented Feb 22, 2022

@jarkkojs
Copy link
Contributor

@haraldh
Copy link
Member

haraldh commented Mar 13, 2022

why did you close this??!!

@haraldh haraldh reopened this Mar 13, 2022
@jarkkojs
Copy link
Contributor

I thought that allocation is done with mmap() et al. I don't see what this task would cover that other tasks do not.

@jarkkojs
Copy link
Contributor

I.e. tasks: #1496, #1506 and #1531.

@haraldh
Copy link
Member

haraldh commented Mar 14, 2022

We need an internal shim allocator in KVM, SNP and SGX.

@haraldh
Copy link
Member

haraldh commented Mar 14, 2022

This is needed to have access to the alloc crate and for Box and drop and all the collections.

When we want to keep poll fd book keeping and other syscall filtering we most likely want to use some collections for it.

@jarkkojs
Copy link
Contributor

OK the issues were quite unclear what the heck they are so I did a big misinterpretation. Sorry about that.

@jarkkojs
Copy link
Contributor

jarkkojs commented May 6, 2022

@haraldh Should I implement this (at some point)? It's pretty easy by reusing mmap() code.

@dpal
Copy link

dpal commented Dec 1, 2022

@haraldh do you know what is the situation here?

@haraldh
Copy link
Member

haraldh commented Jan 27, 2023

I just implemented the global allocator in shim-kvm which enables the use of the alloc crate (part of rust standard libs).

For shim-sgx, we should do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

4 participants