feat: update wasmtime from 5 to 14
#2566
Conversation
|
Related: #2567 |
|
@haraldh Am I on the right track? I'm confused by how the file capability and features was used/needed for exec-wasmtime, and what was removed by the latest Wasmtime release. |
|
Hmm... |
| } else { | ||
| FileCaps::all() | ||
| FileAccessMode::READ |
There was a problem hiding this comment.
Why not all()? I thought the main purpose was to take away TELL and SEEK in case of a tty... of course that does not cover the case of a pipe.
There was a problem hiding this comment.
stdio_file(stdout) only returning FileAccessMode::READ makes no sense somehow
There was a problem hiding this comment.
If there is no FileCaps anymore you can maybe remove this function altogether.
There was a problem hiding this comment.
I wasn't sure since I don't have the context as to why some decisions were made, or what was intended to be accomplished.
There was a problem hiding this comment.
It was done to mark the capabilities of the file descriptor... so a terminal does not have tell and seek capabilities.
FileAccessMode might not make sense here.
| let (file, caps): (Box<dyn WasiFile>, _) = match file { | ||
| File::Null(..) => (Box::new(Null), FileCaps::all()), | ||
| let (file, access): (Box<dyn WasiFile>, _) = match file { | ||
| File::Null(..) => (Box::new(Null), FileAccessMode::WRITE), |
There was a problem hiding this comment.
There is no all.
pub struct FileAccessMode : u32 {
const READ = 0b1;
const WRITE= 0b10;
}There was a problem hiding this comment.
I guess it can be removed completely then
Signed-off-by: Richard Zak <richard.j.zak@gmail.com>
rjzak
force-pushed
the
update_wasmtime
branch
from
4ba90cf
to
a0bdf5c
Compare
Wasmtime is very much outdated. However, the API has changed, especially with handling files.
wasi_common::file::FileCapsis gone, and seemingly replaced by bit flags with far fewer options. I'm not 100% I'm doing this write.Also making this complicated is that writing to files with trait
WasiFileexpects to be able to write to the file with a non-mutable self reference.Note: v14 is the highest version of Wasmtime we can use at the moment since higher versions require newer Rust, but we haven't moved on to newer dependencies to be able to upgrade Rust yet.