Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge sev repo into the enarx repo #71

Merged
merged 94 commits into from
Jan 10, 2020
Merged

Merge sev repo into the enarx repo #71

merged 94 commits into from
Jan 10, 2020

Conversation

npmccallum
Copy link
Member

@npmccallum npmccallum commented Jan 3, 2020 •
edited
Loading

@steveej @mbestavros @lkatalin @haraldh @whitebrandy

There are only two "new" commits in this PR.

  1. The merge commit which pulls in the sev repo's history.
  2. The workspace commit which adds the sev crate to the workspace.

@npmccallum
Initial commit
ca1ebf7
@npmccallum
Remove Result alias
908a028
@npmccallum
Make Error implement Debug
188faeb
@npmccallum
Add platform_status test
0d028d2
@npmccallum
Make command argument optional
d9a9b50
@npmccallum
Rename FactoryReset => PlatformReset
1472044
@npmccallum
Add platform reset command
8816e96 
Don't run the test for this command by default. We don't want to
invalidate people's keys accidentally.
@npmccallum
Add more commands
54266f0 
This commit adds pek_generate, pdh_generate and get_identifer commands.
The first two are not tested by default since they may erase keys in the
hardware.
@npmccallum
Move ioctl declaration and SEV_ISSUE_CMD
f286552 
They are only needed in a single function.
@npmccallum
Use c_void as type for non-argument ioctls()
0fb4356 
This is more clear than using the previous u8 type.
@npmccallum
Group public functions together
ca25246
@npmccallum
Clean up Identifier type
bebfb67 
There will be a future kernel API change here. We have adjusted our API
to handle both the current and future kernel APIs. Also, we added
convenience traits for formatting as hex, since this is how the
identifier is used during online validation.
@npmccallum
Rework the Status structure
a999c43 
The end result should be that it is easier to use.
@npmccallum
Move existing code into subdirectory
1a4a77a
@npmccallum
Add code for parsing certificates
7d1ab03
@npmccallum
Condense Body and Certificate
3ca7856
@npmccallum
Condense Body and Certificate
b0aa2b0
@npmccallum
Consolodate certificate code
62279ae
@npmccallum
Migrate to new AMD ARK certificate
87d7615 
Related: AMDESE/AMDSEV#17
@npmccallum
Rename InvalidSyntax => Invalid
f3c4e4a
@npmccallum
Update for codicon 2.0.0
4bbcf5b
@npmccallum
Don't encode Signature1 separately from Option<Signature1>
ed73aed
@npmccallum
Remove fwapi
03f92b0
@npmccallum
Add TravisCI testing config
1f7b5e6
@npmccallum
Fix build on stable Rust
8d4b0af
@npmccallum
Upgrade earliest Rust test
bc7aff6 
The earliest Rust version we support is 1.32.
@npmccallum
Make Params type private
1dc78f3 
Use the codicon public default type for the Certificate types. Private
types take private Params.
@npmccallum
Rewrite the code for simplicity
6c33099 
Managing two distinct models for each certificate type (multiplied
across versions) has proved to be challenging when writing verification
code. Therefore, we rework the code to have a single Certificate type
with multiple encodings.
@npmccallum
Add certificate validation code
f0f29c8 
All tests pass!
@npmccallum
Prepare for re-merging with fwapi
7dedebe
npmccallum and others added 15 commits April 26, 2019 15:07
@npmccallum
Rework firmware API and externalize tests
e12809f
@npmccallum
Rename Inexhaustive to Indeterminate
3b04ee3
@npmccallum
Rename api module to firmware
43dc865
@npmccallum
Derive Default trait on Policy
a4b8012
@npmccallum
Make Chain members public
159d6fe
@npmccallum
Add test for Session::start()
b7c1fd5 
This test currently fails because of a bug in upstream rust-openssl.
This bug is fixed in master. So we additionally add a patch to fix it.
@npmccallum
Wrap policy with the TIK instead of KIK
6a14a2a
@npmccallum
Fix session generation
c9b0685
@npmccallum
Fix secret generation
1b0bf8c
@npmccallum
License under Apache 2.0
f8f19e0
@mbestavros @npmccallum
Add Apache 2.0 license headers to repository files
e0949c9
@mbestavros @npmccallum
Format code with rustfmt to match Enarx standards
755d668
@mbestavros @npmccallum
Add rustfmt check to Travis tests
8e48a65
@zeenix @npmccallum
Use named fields in Build and Version structs
cbc5d20 
Best use explicit names to clarity purposes.
@mbestavros @steveej
Implement cargo-audit testing in travis
c27c382
@npmccallum npmccallum added the amd sev Issues related to AMD SEV label Jan 3, 2020
@npmccallum npmccallum mentioned this pull request Jan 3, 2020
Closed
@npmccallum
Copy link
Member Author

Due to the inherent merge commit in this PR which causes rebasing this branch to be incredibly annoying, I'm putting a freeze on all other merges until this PR is merged.

Please review this PR ASAP.

@lkatalin @steveej @haraldh @mbestavros

@mbestavros mbestavros self-requested a review January 10, 2020 15:25
mbestavros
mbestavros approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@mbestavros mbestavros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment on duplicate Travis configs. Otherwise, this looks good to go!

sev/.travis.yml Show resolved Hide resolved
@lkatalin lkatalin self-requested a review January 10, 2020 16:16
lkatalin
lkatalin approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@lkatalin lkatalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming these changes were in the SEV repo previously, it looks fine to me. TO DO: Add sev to the Enarx workspace in a separate PR.

@npmccallum npmccallum merged commit 892c703 into enarx:master Jan 10, 2020
@npmccallum npmccallum deleted the sev branch January 10, 2020 17:01
This was referenced Jan 10, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbestavros mbestavros mbestavros approved these changes

@lkatalin lkatalin lkatalin approved these changes

@haraldh haraldh Awaiting requested review from haraldh

Assignees
No one assigned
Labels
amd sev Issues related to AMD SEV
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@npmccallum @mbestavros @lkatalin @zeenix