shim sev/sgx: remove the indirection of the inital function rust call #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced with the static-pie rcrt1 dynamic symbol correction, copying the behaviour of the musl lib rcrt1.o. Apparently it is not necessary to use the indirection, as the code base is not big enough yet, that it exceeds the maximum relative jmp/call distance. If that is ever the case, we should revert this patch.
haraldh
added
amd sev
npmccallum
approved these changes
Aug 5, 2020
|
@haraldh What do we gain by removing this? Easier to read code? |
|
yes |
lkatalin
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced with the static-pie rcrt1 dynamic symbol correction,
copying the behaviour of the musl lib rcrt1.o. Apparently it is not
necessary to use the indirection, as the code base is not big enough
yet, that it exceeds the maximum relative jmp/call distance.
If that is ever the case, we should revert this patch.