Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing more digits for SRA numbers #52

Closed
wants to merge 1 commit into from

Conversation

rpolicastro
Copy link

The regex for SRA accession numbers checks for lengths 6 to 7. However, accession numbers go up to at least 8 digits now. This causes enaDataGet to fail for most new entries. I increased the upper limit to 10 to avoid this.

@puethe
Copy link

puethe commented Aug 3, 2020

Not sure if this has unwanted side effects (I can't see any tests), but if you think it doesn't I would very much appreciate merging this in - it's a blocker for us at the moment.

@raskoleinonen
Copy link
Member

SRA accessions can have 6 or more digits after the three letter prefix. For more information please see:
https://ena-docs.readthedocs.io/en/latest/submit/general-guide/accessions.html

e.g.
Runs | (E|D|S)RR[0-9]{6,} | ERR123456
Analyses | (E|D|S)RZ[0-9]{6,} | ERZ123456

@suranjayathilaka
Copy link
Contributor

This has been fixed in a different PR. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants