Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#51 Make 'templateFile' option required for i18n-bemjson-to-html technology #52

Merged
merged 1 commit into from
Jul 20, 2015

Conversation

tormozz48
Copy link
Contributor

Resolved #51

@blond

Please review it

@tormozz48
Copy link
Contributor Author

Нужно ли повторить эту правку в отдельном pr для ветки v1.x ?
Притом что там есть еще технологии где используется эта опция

@blond
Copy link
Member

blond commented Jul 20, 2015

Нужно ли повторить эту правку в отдельном pr для ветки v1.x ?

Да, нужно.

Притом что там есть еще технологии где используется эта опция

Тогда на все технологии.

@blond
Copy link
Member

blond commented Jul 20, 2015

👍

blond added a commit that referenced this pull request Jul 20, 2015
#51 Make 'templateFile' option required for i18n-bemjson-to-html technology
@blond blond merged commit 72de01d into master Jul 20, 2015
@blond blond removed the review label Jul 20, 2015
@blond blond deleted the issue-51 branch July 20, 2015 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants