Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrency at reading bemjson / html references #74

Closed
xoxulin opened this issue Mar 3, 2015 · 1 comment · Fixed by #77
Closed

Concurrency at reading bemjson / html references #74

xoxulin opened this issue Mar 3, 2015 · 1 comment · Fixed by #77
Assignees
@blond
Milestone
0.11

Comments

@xoxulin
Copy link

xoxulin commented Mar 3, 2015

At reference building all of async calls of html & bemjson files reading, this code every time overrides references values. But sort order in dirs can't be saved at async reading of bemjson / html references.This feature is related to ISLCOMPONENTS-1617 and can break tmpl-specs, e.g. use common level html reference for touch level overriding.
SevInf pushed a commit that referenced this issue Mar 3, 2015
Don't skip istanbul's ignore flags
b51528f 
Istanbul has ability to ignore certain statements, functions or
branches. This information is lost when we are splitting built file
coverage into sources. This patch restores `skip` flags.

Fix #74
@SevInf SevInf mentioned this issue Mar 3, 2015
Merged
@blond blond mentioned this issue Mar 10, 2015
Merged
@blond blond self-assigned this Mar 10, 2015
@blond blond added this to the 0.11 milestone Mar 10, 2015
@blond blond closed this as completed in #77 Mar 10, 2015
@blond
Copy link
Member

blond commented Mar 10, 2015

Fixed in v0.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blond blond

Labels
None yet
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

Fixed bug with reading order of references enb/enb-bem-tmpl-specs
2 participants
@xoxulin @blond