Fix for coverage crash #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0tunn
force-pushed
the
fix/coverage.crash
branch
from
c20a684
to
114d9ec
Compare
j0tunn
force-pushed
the
fix/coverage.crash
branch
from
114d9ec
to
e6a2fa3
Compare
|
@blond 🆙 |
| } else { | ||
| result[key] = value; | ||
| } | ||
| function mergeCoverage(reports) { |
There was a problem hiding this comment.
Я правильно понимаю, что раньше объединение было реализовано не правильно и это не связано с sourcemaps?
There was a problem hiding this comment.
да, это не связано с sourcemaps. Насколько оно было правильно реализовано - это вопрос, т.к. в доке сказано что mergeFileCoverage - это для слияния статистики одного и того же файла, а collector разбирается с этим сам и где нужно как раз и вызывает mergeFileCoverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Мерджим файлы с учетом source maps