This repository has been archived by the owner on Jun 29, 2024. It is now read-only.
Feature/forward heartbeat #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAMEK86
force-pushed
the
feature/forward-heartbeat
branch
from
dd766fd
to
e4084be
Compare
with this, application is able to validate heartbeat data and can implement a watchdog for failsafe watching
with this, application is able to validate heartbeat data and can implement a watchdog for failsafe watching
DAMEK86
force-pushed
the
feature/forward-heartbeat
branch
from
e4084be
to
a62f37d
Compare
# Conflicts: # uclpcserver/types.go # uclppserver/types.go
- Added tests - Changed event name - Fixed possible panic - Corrected/updated heartbeat message check
|
@DAMEK86 thanks for the PR! As discussed I added some tests and minor fixes. Could you please give this a try? |
|
This is implemented in eebus-go repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #38
would be nice to get some tips about the unit test framework.
currently not included. sry