Use provided functions to get connection to prevent deadlock

enbility · Mar 1, 2024 · 0879c03 · 0879c03
1 parent 4e7ca94
commit 0879c03
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/hub/hub_pairing.go b/hub/hub_pairing.go
@@ -89,12 +89,9 @@ func (h *Hub) RegisterRemoteSKI(ski string, enable bool) {
 // Disconnect a connection to an SKI, used by a service implementation
 // e.g. if heartbeats go wrong
 func (h *Hub) DisconnectSKI(ski string, reason string) {
-	h.muxCon.Lock()
-	defer h.muxCon.Unlock()
 
-	// The connection with the higher SKI should retain the connection
-	con, ok := h.connections[ski]
-	if !ok {
+	con := h.connectionForSKI(ski)
+	if con == nil {
 		return
 	}