Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for postgresql+asyncpg DB scheme #395

Closed
mhadam opened this issue Sep 22, 2021 · 1 comment · Fixed by #396
Closed

Add support for postgresql+asyncpg DB scheme #395

mhadam opened this issue Sep 22, 2021 · 1 comment · Fixed by #396

Comments

@mhadam
Copy link
Contributor

mhadam commented Sep 22, 2021 •
edited

The supported DBs dict is missing this scheme prefix.

databases/databases/core.py

Line 45 in 6fcb168

"postgresql": "databases.backends.postgres:PostgresBackend",

mhadam added a commit to mhadam/databases that referenced this issue Sep 22, 2021
@mhadam
Add postgresql+asyncpg scheme prefix (closes encode#395)
4987065
@aminalaee
Copy link
Member

aminalaee commented Sep 23, 2021 •
edited

I think the reason behind this is that we have default database drivers:
postgresql --> asyncpg
mysql --> aiomysql
sqlite --> aiosqlite

Alternatives:
postgresql+aiopg
mysql+asyncmy (work in progress)

Is that causing any problems?

mhadam added a commit to mhadam/databases that referenced this issue Sep 23, 2021
@mhadam
Add SUPPORTED_BACKENDS strategy (closes encode#395)
3c9772a
mhadam added a commit to mhadam/databases that referenced this issue Sep 23, 2021
@mhadam
Add SUPPORTED_BACKENDS strategy (closes encode#395)
f63a98d
@aminalaee aminalaee linked a pull request Sep 24, 2021 that will close this issue
Add postgresql+asyncpg scheme prefix (closes #395) #396
Merged
aminalaee added a commit that referenced this issue Sep 25, 2021
@mhadam @aminalaee
support dialect+driver for default drivers (closes #395) (#396)
3525ca5 
Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add postgresql+asyncpg scheme prefix (closes #395) mhadam/databases
2 participants
@mhadam @aminalaee