Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build queries before acquiring the lock #199

Merged
merged 2 commits into from
Apr 28, 2020

Conversation

vmarkovtsev
Copy link
Contributor

Building the query takes some time, especially if it is big. We hit real performance problems in prod because of that (hundreds of bound parameters, etc.).

@vmarkovtsev
Copy link
Contributor Author

The checks are actually successful, that's the GitHub's CI internals which are not.

@tomchristie
Copy link
Member

@vmarkovtsev Yuck. Okay, let's see if we can re-run that.

Having just moved off travis, I'm really hoping GitHub actions is decently robust.

Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants