Allow password as a callable when using Postgres backend #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm at a loss here - not quite sure how to get to those 100% coverage. Any help would be greatly appreciated :-) |
nwillems
force-pushed
the
postgress_password_callable
branch
from
478831c
to
d66c0c1
Compare
Found out that it was coverage of the supplied function that was missing. Typing is now also added. Should be golden :-) |
vmarkovtsev
requested changes
Oct 19, 2020
nwillems
force-pushed
the
postgress_password_callable
branch
from
e05bf10
to
ca38439
Compare
added 2 commits
November 20, 2020 11:24
Removes the explicit naming of the password parameter for asyncpg, and moves the setting of the password to the kwargs. Further adds tests to ensure that the password argument is preserved.
nwillems
force-pushed
the
postgress_password_callable
branch
from
ca38439
to
691313e
Compare
|
@vmarkovtsev I've updated the code and it should be good - thanks for the review. Hope it fits :-) |
|
Great, thanks for the ping 👍 |
vmarkovtsev
approved these changes
Nov 23, 2020
|
looks like the fix for this actually also fixes a regression that makes it impossible to connect to a postgres db over a unix socket (#257 ). The PR I wrote for that is nearly identical to this. I guess I can close that issue and the associated PR. |
|
Thank you @ugtar 👍 |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended for a case where you have changing passwords for the database, eg when using short-lived tokens.
Specifically, this allows one to use databases together with RDS IAM access, where a token is generated for new connections.