mysql asyncmy driver

[aminalaee]

Fixes #244 .
Adding asyncmy as another mysql driver which is more up to date and faster in some areas.

• Adding asyncmy
• Fixing all tests (raw queries are failing)
• Update the docs

[dkharyna]

@aminalaee @PrettyWood when the changes will be released?

[aminalaee]

@dkharyna I'm waiting for feedback.

[dkharyna]

@dkharyna I'm waiting for feedback.

I see. Thanks for the quick respond.

[aminalaee]

@dkharyna In the meantime, you can also go through this and provide any feedback if you have.

[kirilldd2]

@aminalaee Hi! The main maintainer seems to be AWOL. Is there any way to keep the repo going? Being without python 3.10 support is quite unpleasant :)

[aminalaee]

@Ioloman Hi
I'm trying to spend more time on this repo, hopefully it will get more features/fixes.

As for Python 3.10 it's being added to all repos. I'll get that ready.

[Kludex]

You probably want to split some modifications on a separated PR, like postgres image upgrade, Python 3.10 CI support, etc

I'm not much into this project, so you can also ignore my words 😗

[aminalaee]

@Kludex You're right somehow. I can't seem to get everything working now :D
Actually it was working before but simplified the actions, and now it's failing again.

It's a bit complicated, I can add python 3.10 support as I'm limiting 3.6 for another one. But you're right some of it could be done separately.

[gordthompson]

This seems to work fine for me in my little FastAPI test rig at

https://github.com/gordthompson/fastapi-crud-demo

I would prefer that mysql://… defaulted to asyncmy instead of aiomysql, but I understand that you might not want to do that right away for fear of breaking stuff. Maybe eventually? (It really does look like the whole "aio*" family of drivers has been orphaned.)

[aminalaee]

@gordthompson Thank you for the review.

TBH, I think it would be better to just remove the default database drivers. They can be confusing, we can stick to explicit drivers.

[aminalaee]

@tomchristie Friendly reminder :)

[tomchristie]

I'm just going to leave these ones up to your call @aminalaee.

Generally worth trying to keep different aspects into different PRs (Eg. I notice there's some changes to the development scripts here, which really could be kept separate to the asyncmy driver addition.) But I'm not bothered enough about that to block this from being able to go in, if you think it's ready.

[aminalaee]

I'm just going to leave these ones up to your call @aminalaee.

Generally worth trying to keep different aspects into different PRs (Eg. I notice there's some changes to the development scripts here, which really could be kept separate to the asyncmy driver addition.) But I'm not bothered enough about that to block this from being able to go in, if you think it's ready.

Thanks for the review. You're right I could leave a little bit of that out of this MR, but as you said it wasn't that much.
Basically I had to edit the actions to allow python coverage for python 3.10 and thought now that I'm here, I'd rather fix this.

Will keep that in mind.

[tomchristie]

Yup. To be fair - I do sometimes do the same myself. 🤭