Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap types in typing.Optional where applicable #510

Merged
merged 3 commits into from Dec 17, 2022
Merged

Wrap types in typing.Optional where applicable #510

merged 3 commits into from Dec 17, 2022

Conversation

tsunyoku
Copy link
Contributor

No description provided.

@Kludex
Copy link
Sponsor Member

Kludex commented Oct 20, 2022 •
edited

Hi @tsunyoku ! 馃憢
Would you mind enabling the flag https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-optional on our setup.cfg? That way, we can enforce those changes.

@tsunyoku
Copy link
Contributor Author

Hi @tsunyoku ! 馃憢 Would you mind enabling the flag https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-optional on our setup.cfg? That way, we can enforce those changes.

should be done!

Kludex
Kludex approved these changes Oct 20, 2022
View reviewed changes
Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 馃檹

@Kludex Kludex merged commit 7aa1326 into encode:master Dec 17, 2022
@tsunyoku tsunyoku deleted the fix-typing branch December 17, 2022 19:07
gaetano-guerriero pushed a commit to athenianco/morcilla that referenced this pull request Feb 27, 2023
@tsunyoku @Kludex @gaetano-guerriero
Wrap types in typing.Optional where applicable (encode#510)
79ac95e 
Co-authored-by: tsunyoku <mbruhyo@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsunyoku @Kludex