Skip to content

Commit

Permalink
Removed deprecated '.model' docs
Browse files Browse the repository at this point in the history
  • Loading branch information
maryokhin committed Jan 29, 2015
1 parent ba7dca8 commit e720927
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
8 changes: 2 additions & 6 deletions docs/api-guide/generic-views.md
Expand Up @@ -93,17 +93,13 @@ The following attributes are used to control pagination when used with list view

* `filter_backends` - A list of filter backend classes that should be used for filtering the queryset. Defaults to the same value as the `DEFAULT_FILTER_BACKENDS` setting.

**Deprecated attributes**:

* `model` - This shortcut may be used instead of setting either (or both) of the `queryset`/`serializer_class` attributes. The explicit style is preferred over the `.model` shortcut, and usage of this attribute is now deprecated.

### Methods

**Base methods**:

#### `get_queryset(self)`

Returns the queryset that should be used for list views, and that should be used as the base for lookups in detail views. Defaults to returning the queryset specified by the `queryset` attribute, or the default queryset for the model if the `model` shortcut is being used.
Returns the queryset that should be used for list views, and that should be used as the base for lookups in detail views. Defaults to returning the queryset specified by the `queryset` attribute.

This method should always be used rather than accessing `self.queryset` directly, as `self.queryset` gets evaluated only once, and those results are cached for all subsequent requests.

Expand Down Expand Up @@ -153,7 +149,7 @@ For example:

#### `get_serializer_class(self)`

Returns the class that should be used for the serializer. Defaults to returning the `serializer_class` attribute, or dynamically generating a serializer class if the `model` shortcut is being used.
Returns the class that should be used for the serializer. Defaults to returning the `serializer_class` attribute.

May be overridden to provide dynamic behavior, such as using different serializers for read and write operations, or providing different serializers to different types of users.

Expand Down
2 changes: 1 addition & 1 deletion docs/api-guide/routers.md
Expand Up @@ -28,7 +28,7 @@ There are two mandatory arguments to the `register()` method:

Optionally, you may also specify an additional argument:

* `base_name` - The base to use for the URL names that are created. If unset the basename will be automatically generated based on the `model` or `queryset` attribute on the viewset, if it has one. Note that if the viewset does not include a `model` or `queryset` attribute then you must set `base_name` when registering the viewset.
* `base_name` - The base to use for the URL names that are created. If unset the basename will be automatically generated based on the `queryset` attribute of the viewset, if it has one. Note that if the viewset does not include a `queryset` attribute then you must set `base_name` when registering the viewset.

The example above would generate the following URL patterns:

Expand Down
2 changes: 1 addition & 1 deletion docs/topics/3.0-announcement.md
Expand Up @@ -665,7 +665,7 @@ This code *would be valid* in `2.4.3`:
class Meta:
model = Account

However this code *would not be valid* in `2.4.3`:
However this code *would not be valid* in `3.0`:

# Missing `queryset`
class AccountSerializer(serializers.Serializer):
Expand Down

0 comments on commit e720927

Please sign in to comment.