New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live API docs (#4755) makes markdown
dependency non-optional
#4941
Comments
👍 blocker for 3.6 |
We don't really need that extension - it was more of a hangover from first pass at building the API docs. I've removed it for now - if we do add any markdown extensions to it we can make sure to do so in an optional dependency manner. |
The "fix" for this issue was insufficient. Note the line in
This unconditionally tries to import the name
The name |
Thanks @intgr - I'll take a look at addressing that now. |
Hello,
How to fix that? Thanks. |
@micheledallatorre - Should be resolved as of just now. Upgrade to 3.6.1 (Or install the |
Thank you. |
@tomchristie I am on 3.6.2 and still getting this error. When I added django markdown to requirements, this got resolved but I started getting a different error when trying to run celery - |
@tomchristie I am on python 3.6.1, have markdown installed and still get the following error: Invalid template library specified. ImportError raised when trying to load 'rest_framework.templatetags.rest_framework': No module named 'django.urls' |
What Django version are you running? |
@carltongibson I'm using Django 1.9.0 |
Django 1.9 is End of Life and no-longer supported. You should upgrade to Django 1.11 LTS or Django 2.0 |
thanks, @carltongibson, I installed Django 2.0, it now works. |
rest_framework.templatetags.rest_framework
is non-conditionally importingmarkdown
.https://github.com/tomchristie/django-rest-framework/blob/master/rest_framework/templatetags/rest_framework.py#L12-L16
As per the
compat
importmarkdown
has previously been an optional dependency. It's still listed as an optional requirementWithout
markdown
installed, the template tags can no longer be imported. cf carltongibson/django-filter#658Markdown either needs to be declared required or a work around is needed.
The text was updated successfully, but these errors were encountered: