Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial fixes #3636 and fixes #3637 #3787

Merged
merged 2 commits into from Jan 1, 2016
Merged

Initial fixes #3636 and fixes #3637 #3787

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef49168
Initial fixes #3636 and fixes #3637
lsanpablo Jan 1, 2016
183f8fa
Class formatting
lsanpablo Jan 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions docs/api-guide/filtering.md
View file
Open in desktop
Expand Up @@ -177,7 +177,7 @@ For more advanced filtering requirements you can specify a `FilterSet` class tha
from rest_framework import filters
from rest_framework import generics

class ProductFilter(django_filters.FilterSet):
class ProductFilter(filters.FilterSet):
min_price = django_filters.NumberFilter(name="price", lookup_type='gte')
max_price = django_filters.NumberFilter(name="price", lookup_type='lte')
class Meta:
Expand All @@ -199,12 +199,12 @@ You can also span relationships using `django-filter`, let's assume that each
product has foreign key to `Manufacturer` model, so we create filter that
filters using `Manufacturer` name. For example:

import django_filters
from myapp.models import Product
from myapp.serializers import ProductSerializer
from rest_framework import filters
from rest_framework import generics

class ProductFilter(django_filters.FilterSet):
class ProductFilter(filters.FilterSet):
class Meta:
model = Product
fields = ['category', 'in_stock', 'manufacturer__name']
Expand All @@ -218,9 +218,10 @@ This is nice, but it exposes the Django's double underscore convention as part o
import django_filters
from myapp.models import Product
from myapp.serializers import ProductSerializer
from rest_framework import filters
from rest_framework import generics

class ProductFilter(django_filters.FilterSet):
class ProductFilter(filters.FilterSet):
manufacturer = django_filters.CharFilter(name="manufacturer__name")

class Meta:
Expand Down