New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed multi-table inheritance auto created PK from serialize. #4852
Conversation
Some build failures on Python 3.6 which look unrelated to this. Just restarting the build now. |
This PR fixed two failures on Django 1.11
I'm working on |
Those python 3.6 failures should be in |
Maybe try re-issuing the Pull Request to see if that resolves things now, given @rpkilby's comment that travis have now resolved this issue. Restarting the build didn't fix things. |
They will deploy fix in the week (see travis-ci/travis-ci#7221 (comment)). |
…from serialize.
I rebased from master. Now it works 🎉. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. There's already a failing test, which now passes.
(It just leaves a few test_schema
issues for Django 1.11/master
compat.)
👍 Fab - thanks! |
I found (django/django@f0ef0c4) and fixed (django/django@092f09f) regression in Django. Tests In the beta release 1.11b1 should pass correctly. You can check it with 1.11.x.tar.gz. |
* master: (95 commits) Add max_length and min_length arguments for ListField (encode#4877) Update sponsors on README to include rollbar (encode#4876) Added Rollbar to premium sponsors fixed url checker ':' to 'http' (encode#4678) Fixed `dedent` for tab indent. Add test for pagination when limit not set Fixed Django 2.0 compatibility due to `django.conf.urls.include` parameters change. (encode#4866) Add remaining tests for generics (encode#4865) Removed unnecessary importlib wrapper. Updated Support section and added funding email (encode#4860) Git add remaining tests for BaseSerializer (encode#4857) Update machinalis links Updated Machinalis links (encode#4856) Add remaining tests for metadata (encode#4855) Fixed encode#4574 -- Removed multi-table inheritance auto created PK from serialize. (encode#4852) Add couple of tests for filters (encode#4849) Refactor according to comments in PR (encode#4848) Add couple of tests for compat module (encode#4845) Direct readers to info on how to add viewset docs (encode#4844) Fixed test_one_to_one_with_inheritance. Added required on_delete attribute to OneToOneField field. (encode#4838) ...
Fixed #4574 and carltongibson/django-filter#607.
Bisected to django/django@74a575e (see [1]).