Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't make the content mandatory in the generic content form #5372

Merged
merged 1 commit into from Sep 4, 2017

Conversation

dvarrazzo
Copy link
Contributor

@dvarrazzo dvarrazzo commented Aug 29, 2017

Sometimes, probably in the upgrade from Django 1.9 to 1.10, a post with
empty content is forbidden by javascript, with the message "Please fill
in this field". Filling the form with '{}' allows an application/json
request to be submitted.

The API call itself works perfectly well with a post with empty content:
the interface shouldn't make assumptions about it.

Sometimes, probably in the upgrade from Django 1.9 to 1.10, a post with
empty content is forbidden by javascript, with the message "Please fill
in this field". Filling the form with '{}' allows an application/json
request to be submitted.

The API call itself works perfectly well with a post with empty content:
the interface shouldn't make assumptions about it.
@tomchristie
Copy link
Member

tomchristie commented Sep 4, 2017

Fair enough! :)

@tomchristie tomchristie merged commit e42eb42 into encode:master Sep 4, 2017
@tomchristie tomchristie added this to the 3.6.5 Release milestone Sep 4, 2017
@tomchristie tomchristie added the Bug label Sep 4, 2017
@dvarrazzo dvarrazzo deleted the content-not-mandatory branch Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants