Fix timezone handling for DateTimeField #5408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 11, 2017 04:56
- tests "current" timezone activation - tests output for non-UTC timezones
rpkilby
commented
Sep 11, 2017
| @@ -1165,7 +1170,7 @@ class TestDateTimeField(FieldValues): | |||
| datetime.date(2001, 1, 1): ['Expected a datetime but got a date.'], | |||
| } | |||
| outputs = { | |||
| datetime.datetime(2001, 1, 1, 13, 00): '2001-01-01T13:00:00', | |||
| datetime.datetime(2001, 1, 1, 13, 00): '2001-01-01T13:00:00Z', | |||
There was a problem hiding this comment.
Side note - changed the datetime output from unaware to aware/UTC datetime, since the field itself is datetime-aware.
carltongibson
approved these changes
Sep 11, 2017
There was a problem hiding this comment.
This looks great. @rpkilby happy for you to merge when you’re ready. (Not sure if you want to wait for confirmation.)
Nice!
|
Yeah, I'll give it a few days for confirmation. |
clintonb
approved these changes
Sep 13, 2017
auvipy
approved these changes
Sep 13, 2017
|
Seems good. Will we want to mention any behavioral changes here in the release notes? |
|
|
@rpkilby - Okay, we'll want to think this over slightly when we come to writing the release notes. Needs to be a little clearer I think. |
|
(Otherwise great tho!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #3732, as well as the current/active timezone handling mentioned by @RichardForshaw.