Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.0a1 compat #5503

Merged
merged 4 commits into from Oct 16, 2017
Merged

Conversation

carltongibson
Copy link
Collaborator

@carltongibson carltongibson commented Oct 16, 2017

Following from #5500, fixing failures against Django 2.0a1

Missed as part of encode#5481 cleanup.
@carltongibson carltongibson added this to the 3.7.1 Release milestone Oct 16, 2017
@carltongibson
Copy link
Collaborator Author

carltongibson commented Oct 16, 2017

@rpkilby There's a change in Django 2.0 which brings back issues around #4622. It's just a single failure now, but of course nothing about get_FOO_display in the release notes. Any thoughts?

@carltongibson
Copy link
Collaborator Author

carltongibson commented Oct 16, 2017

@rpkilby They made get_FOO_display a functools.partial. Checking for this fixes the issue.

@rpkilby
Copy link
Member

rpkilby commented Oct 16, 2017

I'm trying to remember - is there a reason we don't just use a callable check there?

@rpkilby
Copy link
Member

rpkilby commented Oct 16, 2017

oh - right. Classes are also callables.

That said, I don't know if that really matters. Is there a reason to exclude classes here? Or other non-method/non-functions for that matter?

@carltongibson
Copy link
Collaborator Author

carltongibson commented Oct 16, 2017

OK, this is green. Django2.0a1 is GO! 🎉

  • I'll leave django20 as an allowed failure for now. We can tighten up nearer release.
  • There's only a small number of failures on djangomaster — looks like the contrib.auth views are on the move.

This is where we wanted to be for today.

@rpkilby Thanks for the input!

@carltongibson carltongibson merged commit c7fb60b into encode:master Oct 16, 2017
1 check passed
@carltongibson carltongibson deleted the 371/django-20-compat branch Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants