Update checks.py #5523
Closed
Update checks.py #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carltongibson
added a commit
to carltongibson/django-rest-framework
that referenced
this pull request
Oct 23, 2017
* Add uid=501(carlton) gid=20(staff) groups=20(staff),250(com.apple.access_backup),401(com.apple.sharepoint.group.1),12(everyone),61(localaccounts),79(_appserverusr),80(admin),81(_appserveradm),98(_lpadmin),402(com.apple.sharepoint.group.2),33(_appstore),100(_lpoperator),204(_developer),395(com.apple.access_ftp),398(com.apple.access_screensharing),399(com.apple.access_ssh) to allow silencing. * Expand to clarify. Ref encode#5170 Closes encode#5523
carltongibson
added a commit
to carltongibson/django-rest-framework
that referenced
this pull request
Oct 23, 2017
* Add `id` to allow silencing. * Expand `hint` to clarify. Ref encode#5170 Closes encode#5523
|
Hi @novelview9. The system check logic is as intended. It fires just when you have PAGE_SIZE set but not DEFAULT_PAGINATION_CLASS. I've added #5524 to clarify the hint and add an Thanks for the input! |
carltongibson
added a commit
that referenced
this pull request
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #5170
Description
If statement caused the error in normal cases without the solution before.
so I changed if statement to check only in user-settings and give solution and hint to handle that error