Compat cleanup #5581
Merged
Compat cleanup #5581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdufresne
reviewed
Nov 9, 2017
rest_framework/compat.py
Outdated
| @@ -254,7 +249,7 @@ def md_filter_add_syntax_highlight(md): | |||
| return False | |||
|
|
|||
| try: | |||
| import pytz | |||
| import pytz # noqa | |||
There was a problem hiding this comment.
Starting with Django 1.11, pytz is a Django requirement. So django-rest-framework can expect it to exist. I think adding a comment with this information would be helpful so that when Django 1.10 is dropped it is noticed and this workaround is removed.
... when dropping Django 1.10
Grrr. GitHub web editor 😡
|
Was there really an urgency to remove pytz ? |
|
Just added a note so that we remember when the time comes. pytz will become a hard requirement, so we’ll be able to drop the compat shim. |
| @@ -253,8 +248,9 @@ def md_filter_add_syntax_highlight(md): | |||
| def md_filter_add_syntax_highlight(md): | |||
| return False | |||
|
|
|||
| # pytz is required from Django 1.11. Remove when dropping Django 1.10 support. | |||
There was a problem hiding this comment.
@xordoquy it’s just this comment. Nothing is actually changed yet.
|
oh, perfect ! |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* Reenable flake8 on compat, cleanup style/imports * Cleanup compat urls imports * Refactor compat url pattern/resolver imports * Add comment re dropping pytz compat ... when dropping Django 1.10 * Strip whitespace Grrr. GitHub web editor 😡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatmodule, which is why whitespace issues went undetected by the linter. Removed the global noqa and re-added where necessary to individual lines.RegexURLPattern=>URLPatternRegexURLResolver=>URLResolver