Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always fully qualify ValidationError in docs #5751

Merged
merged 1 commit into from Jan 19, 2018
Merged

Always fully qualify ValidationError in docs #5751

merged 1 commit into from Jan 19, 2018

Conversation

tkazec
Copy link
Contributor

@tkazec tkazec commented Jan 19, 2018

As specified in the exceptions documentation:

By convention you should import the serializers module and use a fully qualified ValidationError

Most examples in the serializers documentation followed this convention, but there were several cases (including three confusing lines of code) that didn't.

Copy link
Collaborator

@carltongibson carltongibson left a comment

OK. Yes. This seems reasonable.

Thanks!

@carltongibson carltongibson added this to the 3.8 Release milestone Jan 19, 2018
@carltongibson carltongibson merged commit 78367ba into encode:master Jan 19, 2018
1 check passed
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants