Update to Django 2.0 Routing Syntax #6049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the code in tutorial part 6, "Using Routers", to Django 2.0 routing syntax using path().
blueyed
suggested changes
Jun 21, 2018
| @@ -3,7 +3,6 @@ | |||
| REST framework includes an abstraction for dealing with `ViewSets`, that allows the developer to concentrate on modeling the state and interactions of the API, and leave the URL construction to be handled automatically, based on common conventions. | |||
|
|
|||
| `ViewSet` classes are almost the same thing as `View` classes, except that they provide operations such as `read`, or `update`, and not method handlers such as `get` or `put`. | |||
|
|
|||
There was a problem hiding this comment.
I think I erased that line by accident, will add it back in. Thanks!
blueyed
suggested changes
Jun 21, 2018
| @@ -116,7 +116,7 @@ Here's our re-wired `snippets/urls.py` file. | |||
|
|
|||
| # The API URLs are now determined automatically by the router. | |||
| urlpatterns = [ | |||
| url(r'^', include(router.urls)) | |||
| path('', include(router.urls)), | |||
There was a problem hiding this comment.
path should also be imported then instead of url - sorry for missing this earlier.
You can add [ci skip] to not trigger a CI run.
There was a problem hiding this comment.
My bad, where would I add the [ci skip]?
There was a problem hiding this comment.
Damn, just realized I should've included it in the commit message, already committed...
There was a problem hiding this comment.
I'm not 100% sure, but I don't think non-members/collaborators can issue a [ci skip].
Fixed the import statement in tutorial part 6 for the path() and include() functions.
blueyed
approved these changes
Jun 21, 2018
|
Thanks for reviewing my work! |
carltongibson
approved these changes
Jun 22, 2018
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the code in tutorial part 6, "Using Routers", to Django 2.0
routing syntax using path(). Refs #5964, there was one missing bit that wasn't updated.