New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support django 2.1+ test client json data automatically serialized #6511
base: master
Are you sure you want to change the base?
support django 2.1+ test client json data automatically serialized #6511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to have a better review need to add a test for the proposed change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely going to agree with @auvipy here. A test case demonstrating the behavior change would be required for this to be accepted.
My immediate reaction is "why aren't our tests failing under Django 2.1+?"
4607f28
to
4ed1e0e
Compare
@rpkilby updated with a test |
d368885
to
0a99e02
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
0a99e02
to
9ee6d46
Compare
Updated to |
9ee6d46
to
09fafd2
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
09fafd2
to
d28724e
Compare
bumped, I think the failed test was unrelated but this re-run the test suite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, please rebase, and I think we might get rid of some checks to eleminate older version check
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
d28724e
to
d579cc1
Compare
The failing test should be fixed by #9129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you rebase? and check if any document or test update is needed to get this merged? also a reference to django docs related to this would be really helpful
d579cc1
to
803e089
Compare
It's mentioned here https://docs.djangoproject.com/en/4.2/topics/testing/tools/#django.test.Client.post (specifically), and it's mentioned in the 2.1 release notes https://docs.djangoproject.com/en/4.2/releases/2.1/#tests (point 2) I'm not sure if you're asking for this to be included in the source, since there's not specifically a good place to put it (maybe the tests?), or if you're just asking for the release notes. |
Description
_encode_data
is alwaysTuple[bytes, str]
rather thanTuple[Union[bytes,str], str]