Fix OpenAPI operation name plural appropriately #8017
Merged
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Certainly going to be neater than what we're currently doing. |
tomchristie
approved these changes
Jun 7, 2021
|
Thank you for reviewing! I don't know why CI is failing... |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
heavenshell
force-pushed
the
topic/openapi-operation-plural
branch
from
480f486
to
7cf5c19
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
auvipy
approved these changes
Nov 24, 2022
|
the only build failure is a doc related failure, which does not seem to be related to this PR |
|
@auvipy Thank you so much! 👍 |
tfranzel
added a commit
to tfranzel/django-rest-framework
that referenced
this pull request
Nov 28, 2022
|
pretty sure this broke the build by introducing a new hard dependency through the backdoor. see #8781 |
auvipy
pushed a commit
that referenced
this pull request
Nov 28, 2022
cweider
added a commit
to cweider/courtlistener
that referenced
this pull request
Aug 23, 2023
A dependency on encode/django-rest-framework#8017 and later made less obtrusive by encode/django-rest-framework#8781, but it did not eliminate it. Any usage of the schema generator must be done in an environment that includes this package.
cweider
added a commit
to cweider/courtlistener
that referenced
this pull request
Aug 23, 2023
A dependency on encode/django-rest-framework#8017 and later made less obtrusive by encode/django-rest-framework#8781, but it did not eliminate it. Any usage of the schema generator must be done in an environment that includes this package.
cweider
added a commit
to cweider/courtlistener
that referenced
this pull request
Aug 23, 2023
`django-rest-framework` has recieved several patches for CSP compatibility, but unfortunately these are not included in the latest release (3.14.0) and a new release cannot be expected for a while. As such, we must replace the semantically versioned PyPI reference with a reference to the latest commit on the master branch of the package's Git Repository that contains the changes that we need (do not use `master` since it could change in unexpected and incompatible ways). Included in this change is the `inflection` package, unfortunate dependency added by encode/django-rest-framework#8017 and later made less obtrusive by encode/django-rest-framework#8781, but it did not eliminate it. Any usage of the schema generator must be done in an environment that includes this package. Fixes: freelawproject#3020
cweider
added a commit
to cweider/courtlistener
that referenced
this pull request
Aug 23, 2023
`django-rest-framework` has recieved several patches for CSP compatibility, but unfortunately these are not included in the latest release (3.14.0) and a new release cannot be expected for a while. As such, we must replace the semantically versioned PyPI reference with a reference to the latest commit on the master branch of the package's Git Repository that contains the changes that we need (do not use `master` since it could change in unexpected and incompatible ways). Included in this change is the use of `inflection` for the OpenAPI spec's `operationIds`, an unfortunate dependency added by encode/django-rest-framework#8017 and later made less obtrusive by encode/django-rest-framework#8781. Any usage of the schema generator must be done in an environment that includes this package. Additionally, this new approach makes the generated `operationId` that was `listPersons` into `listPeople`. Thankfully, this is immaterial. Fixes: freelawproject#3020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is re-challenge of #7447
I introduced inflection library to pluralize appropriately.
It would be very grateful to review this 😊
Thank you.