Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --version CLI option to generateschema #8552

Conversation

erancihan
Copy link
Contributor

@erancihan erancihan commented Jul 11, 2022

Description

Adds support for --version CLI argument to generateschema management command.

refs #8551

@wieczorek1990
Copy link
Contributor

Seems ok.

@tomchristie tomchristie merged commit 3401ef5 into encode:master Sep 21, 2022
@tomchristie
Copy link
Member

Thanks!

@tomchristie tomchristie mentioned this pull request Sep 21, 2022
@tomchristie
Copy link
Member

Right, I need to be a bit tedious here.
Looks like this change introduced a failing CI under Python 3.6.

See here: https://github.com/encode/django-rest-framework/actions/runs/3097673683/jobs/5014619905

I don't understand what the issue is, but it'd need to be resolved in order for us to merge this. Until then I've reverted this with #8661.

I know. Boring. 😑

@erancihan
Copy link
Contributor Author

Well... this is awkward.

I'll take care of this later on and open a new PR.

Sorry for the inconvenience.

@erancihan
Copy link
Contributor Author

Yep this is on me.

It conflicts with the version arg in the management BaseCommand.
For now, I'm renaming it to api_version as it indicates the API's version that is present in the generated schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants