Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix to SerializerMethodField docstring #8629

Merged
merged 1 commit into from Oct 3, 2022
Merged

Minor fix to SerializerMethodField docstring #8629

merged 1 commit into from Oct 3, 2022

Conversation

manelbdcosta
Copy link
Contributor

@manelbdcosta manelbdcosta commented Aug 31, 2022 •
edited

Description

Very minor fix to SerializerMethodField docstring. It now follows the same pattern as the example in the docstring of ReadOnlyField

DarknessRdg
DarknessRdg approved these changes Oct 2, 2022
View reviewed changes
Copy link

@DarknessRdg DarknessRdg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Well done in that doc mistake haha

tomchristie
tomchristie approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@tomchristie tomchristie merged commit 79de112 into encode:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

@DarknessRdg DarknessRdg DarknessRdg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manelbdcosta @tomchristie @DarknessRdg