Use correct class to indicate present deprecation #8665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PendingDeprecationWarning` means "we plan to deprecate, but haven't yet." A feature that's to be deleted in the next release is not planned to be deprecated; it **is** deprecated. > Base class for warnings about features which are obsolete and expected > to be deprecated in the future, but are not deprecated at the moment. > > This class is rarely used as emitting a warning about a possible > upcoming deprecation is unusual, and DeprecationWarning is preferred for > already active deprecations. https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning
kevin-brown
approved these changes
Sep 22, 2022
sigvef
pushed a commit
to sigvef/django-rest-framework
that referenced
this pull request
Dec 3, 2022
`PendingDeprecationWarning` means "we plan to deprecate, but haven't yet." A feature that's to be deleted in the next release is not planned to be deprecated; it **is** deprecated. > Base class for warnings about features which are obsolete and expected > to be deprecated in the future, but are not deprecated at the moment. > > This class is rarely used as emitting a warning about a possible > upcoming deprecation is unusual, and DeprecationWarning is preferred for > already active deprecations. https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning Co-authored-by: Tom Christie <tom@tomchristie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PendingDeprecationWarningmeans "we plan to deprecate, but haven't yet." A feature that's to be deleted in the next release is not planned to be deprecated; it is deprecated.(emphasis mine)
https://docs.python.org/3/library/exceptions.html#PendingDeprecationWarning