Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] add missing DurationField to SimpleMetada label_lookup #8702

Merged
merged 1 commit into from Nov 21, 2022
Merged

[FIX] add missing DurationField to SimpleMetada label_lookup #8702

merged 1 commit into from Nov 21, 2022

Conversation

smt-insens
Copy link
Contributor

@smt-insens smt-insens commented Oct 14, 2022 •
edited

refs #8700

@smt-insens smt-insens force-pushed the fix-duration_field_metadata_label_lookup branch from c616690 to 4f2bbc3 Compare October 14, 2022 20:47
@smt-insens
Copy link
Contributor Author

@tomchristie could you have a look on this PR? Thank you!

@auvipy auvipy self-requested a review November 21, 2022 13:59
@auvipy
Copy link
Member

auvipy commented Nov 21, 2022

Hey, new maintainer here! thanks for your patch. I will make a thorough review and see if anything else is needed or we are good to go with this as is

auvipy
auvipy approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auvipy auvipy merged commit dc300aa into encode:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smt-insens @auvipy