Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Django urls #8778

Merged
merged 1 commit into from Nov 27, 2022
Merged

Register Django urls #8778

merged 1 commit into from Nov 27, 2022

Conversation

tomirgang
Copy link
Contributor

Without adding the URLs manually, the users and groups APIs were not usable.

My env:
(venv) ➜ tutorial pip freeze
asgiref==3.5.2
astroid==2.12.13
autopep8==2.0.0
dill==0.3.6
Django==4.1.3
djangorestframework==3.14.0
isort==5.10.1
lazy-object-proxy==1.8.0
mccabe==0.7.0
platformdirs==2.5.4
pycodestyle==2.10.0
pylint==2.15.6
pylint-django==2.5.3
pylint-plugin-utils==0.7
pytz==2022.6
sqlparse==0.4.3
tomli==2.0.1
tomlkit==0.11.6
wrapt==1.14.1

Note: Before submitting this pull request, please review our contributing guidelines.

Description

Please describe your pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. When linking to an issue, please use refs #... in the description of the pull request.

Without adding the URLs manually, the users and groups APIs were not usable.

My env:
(venv) ➜  tutorial pip freeze
asgiref==3.5.2
astroid==2.12.13
autopep8==2.0.0
dill==0.3.6
Django==4.1.3
djangorestframework==3.14.0
isort==5.10.1
lazy-object-proxy==1.8.0
mccabe==0.7.0
platformdirs==2.5.4
pycodestyle==2.10.0
pylint==2.15.6
pylint-django==2.5.3
pylint-plugin-utils==0.7
pytz==2022.6
sqlparse==0.4.3
tomli==2.0.1
tomlkit==0.11.6
wrapt==1.14.1
@auvipy auvipy merged commit 3bf6117 into encode:master Nov 27, 2022
@auvipy
Copy link
Member

auvipy commented Nov 27, 2022

thanks for catching and fixing it!

@auvipy auvipy added the Bug label Nov 27, 2022
@tomirgang tomirgang deleted the patch-1 branch November 27, 2022 14:03
@auvipy auvipy added this to the 3.15 milestone Sep 21, 2023
shuuji3 added a commit to shuuji3/django-rest-framework that referenced this pull request Feb 12, 2024
@auvipy
Copy link
Member

auvipy commented Feb 19, 2024

we have a regression and revert request for this, can you recheck

@igorgaming
Copy link

This PR is definitely wrong and must be reverted

auvipy pushed a commit that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants