Remove a bit of inline CSS. Add CSP nonce where it might be required and is available. #8783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and is available.
juspence
commented
Nov 29, 2022
| {% get_pagination_html paginator %} | ||
| </nav> | ||
| {% endif %} | ||
|
|
||
| <div class="request-info" style="clear: both" aria-label="{% trans "request info" %}"> |
There was a problem hiding this comment.
clear: both was already in request-info.
auvipy
requested changes
Nov 30, 2022
|
@auvipy Sorry for the delayed response. Here's before: And after: |
auvipy
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Copied from #7960, but nonce removed to avoid conflicts with user-defined policies)
Remove a few instances of inline CSS which could trigger Content Security Policies (CSPs) and replace with classes where required.
Part of #6069.
I've left JavaScript alone as it's covered by #5740 and #7016 (which I think are duplicates of each other?).