New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version of jQuery to 3.6.4 & updated ref links #8909
Conversation
Hey forgive me for asking but can't we link against |
that's a good question! DRF uses twitter bootstrap which django admin doesn't. I followed the historical approach here. But if old maintainer of the project suggest for using django admins jquery I will update accordingly. another point to consider here is that, the latest version of twbs has stopped using jquery & switched to vanilla JS. as DRF will also upgrade it's twbs version, it most likely will drop usage of jquery |
@tschwaerzl did you notice any regression in existing UI's?? |
This is a good answer. Thanks :D Should i adress this in a Issue that can get the maintainers attention or should i ping here? |
I am also a maintainer now for your kind info :) |
I'm fairly certain that Django is also in the process of dropping the dependency on jQuery so I don't think it makes sense to switch over to that one at this time. I'm fine updating our vendored version to a newer one, but we should also look towards removing the dependency in the future. I'm pretty sure we'd also have to take a new dependency against Django's admin, which I don't think we otherwise require. |
I think we should only focus on DRF vendroed version for now as this fix some security / other bugs. and for future, moving away from jquery |
I am fairly certain thats not happening The reasoning is that too many dependencies require jQuery to be present in django admin ( eg:
Fair enough. I respect your opinion.
If my opinion matters. No i didn't find any regression during my initial ( albeit very light testing )
Apologies. I was not aware of this. Forgive my rude response from before. ( Congratulations !! ) Since django also updated their jquery to 3.6.4 i think we can move with this. |
No issues found. Everything working as it should be. |
never mind my comment was purely pun intended! no offense taken! you views are highly appreciated. the only reasoning here against using django jquery is, DRF is based on twbs. that's the issue. If you guys can confirm no regression happening and also check the version file in this PR is security checked then I can merge this. |
we have another followup PR #9094 |
No description provided.