Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement __eq__ for validators #8925

Merged
merged 2 commits into from Apr 9, 2023

Conversation

max-muoto
Copy link
Contributor

Note: Before submitting this pull request, please review our contributing guidelines.

Description

Implement equality operator for validators and add test coverage.

Fixes #8905.

@max-muoto max-muoto marked this pull request as ready for review April 2, 2023 21:13
@auvipy auvipy self-requested a review April 3, 2023 07:15
@auvipy auvipy added this to the 3.15 milestone Apr 8, 2023
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we find any place for documentation improvement?

@max-muoto
Copy link
Contributor Author

should we find any place for documentation improvement?

I added a sentence on the fact that they implement __eq__ like their Django counterparts in the validation documentation if that suffices. Let me know what you think.

@auvipy auvipy merged commit 0d6ef03 into encode:master Apr 9, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validators do not implement __eq__ method
2 participants