Replaced all-encompassing ignore of PIE786 with specific noqa comments

encode · Sep 12, 2020 · 8e19ae3 · 8e19ae3
1 parent a4e37a6
commit 8e19ae3
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/httpcore/_async/connection.py b/httpcore/_async/connection.py
@@ -112,7 +112,7 @@ async def _open_socket(self, timeout: TimeoutDict = None) -> AsyncSocketStream:
                 return await self.backend.open_uds_stream(
                     self.uds, hostname, ssl_context, timeout
                 )
-        except Exception:
+        except Exception:  # noqa: PIE786
             self.connect_failed = True
             raise
 

diff --git a/httpcore/_async/connection_pool.py b/httpcore/_async/connection_pool.py
@@ -192,7 +192,7 @@ async def request(
                 )
             except NewConnectionRequired:
                 connection = None
-            except Exception:
+            except Exception:  # noqa: PIE786
                 logger.trace("remove from pool connection=%r", connection)
                 await self._remove_from_pool(connection)
                 raise

diff --git a/httpcore/_async/http2.py b/httpcore/_async/http2.py
@@ -124,7 +124,7 @@ async def request(
             self.streams[stream_id] = h2_stream
             self.events[stream_id] = []
             return await h2_stream.request(method, url, headers, stream, timeout)
-        except Exception:
+        except Exception:  # noqa: PIE786
             await self.max_streams_semaphore.release()
             raise
 

diff --git a/httpcore/_exceptions.py b/httpcore/_exceptions.py
@@ -6,7 +6,7 @@
 def map_exceptions(map: Dict[Type[Exception], Type[Exception]]) -> Iterator[None]:
     try:
         yield
-    except Exception as exc:
+    except Exception as exc:  # noqa: PIE786
         for from_exc, to_exc in map.items():
             if isinstance(exc, from_exc):
                 raise to_exc(exc) from None

diff --git a/httpcore/_sync/connection.py b/httpcore/_sync/connection.py
@@ -112,7 +112,7 @@ def _open_socket(self, timeout: TimeoutDict = None) -> SyncSocketStream:
                 return self.backend.open_uds_stream(
                     self.uds, hostname, ssl_context, timeout
                 )
-        except Exception:
+        except Exception:  # noqa: PIE786
             self.connect_failed = True
             raise
 

diff --git a/httpcore/_sync/connection_pool.py b/httpcore/_sync/connection_pool.py
@@ -192,7 +192,7 @@ def request(
                 )
             except NewConnectionRequired:
                 connection = None
-            except Exception:
+            except Exception:  # noqa: PIE786
                 logger.trace("remove from pool connection=%r", connection)
                 self._remove_from_pool(connection)
                 raise

diff --git a/httpcore/_sync/http2.py b/httpcore/_sync/http2.py
@@ -124,7 +124,7 @@ def request(
             self.streams[stream_id] = h2_stream
             self.events[stream_id] = []
             return h2_stream.request(method, url, headers, stream, timeout)
-        except Exception:
+        except Exception:  # noqa: PIE786
             self.max_streams_semaphore.release()
             raise