Broken timeout

[karpetrosyan]

timeout argument doesn't work

server.py

import asyncio
from fastapi import FastAPI

app = FastAPI()

@app.get("/slow_response")
async def slow_request():
    await asyncio.sleep(10)

test.py

@pytest.mark.anyio
async def test_timeout_exception(app):
    async with httpx.AsyncClient(app=app, base_url="https://example.com", timeout=1) as client:
        await client.get("/slow_response", timeout=1)

$ time pytest tests/test_downloader.py::test_timeout_exception 
.                                                                                                                                                                                                                           [100%]
1 passed in 10.11s
pytest tests/test_downloader.py::test_timeout_exception -q  0.58s user 0.07s system 6% cpu 10.665 total

How this works? The request takes 10 seconds but it works fine with 1 second timeout

[tomchristie]

Timeouts aren't currently supported when interacting with an ASGI or WSGI app.
They're only applied if you're making actual network requests.
We should probably start by documenting this, we could then follow up by determining if we want to change that behaviour or not.

[charfa]

I assume nothing has changed regarding this topic? I'm facing the same issue now and would like to cast my vote for adding timeout support for ASGI apps.

I'm using httpx to test my FastAPI server, and as is, if the server fails to respond for some reason, the test will hang until the job on CI times out. I can work around it by wrapping every client call in asyncio.wait_for, but it would be so much nicer to set the timeout once when creating the client instance.

[karpetrosyan]

We have timeouts for connect, read, write, and pool operations, which are handled by httpcore during network operations. It seems like they do not make any sense when we don't have any IO.
Maybe it will make more sense once we add overall timeout support.