Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockers for 1.0 release. #137

Closed
3 of 12 tasks
tomchristie opened this issue Jul 23, 2019 · 10 comments
Closed
3 of 12 tasks

Blockers for 1.0 release. #137

tomchristie opened this issue Jul 23, 2019 · 10 comments
Milestone

Comments

@tomchristie
Copy link
Member

tomchristie commented Jul 23, 2019

List of things that I currently think are required for a 1.0 release.

We should try to keep this scope as narrow as possible. Anything related to the external API is fair game, plus any critical level implementation issues.

Anything else that doesn't meet those criteria should be regarded as not strictly required for 1.0.

Am I missing anything else that strictly needs to get onto this list?

@sethmlarson
Copy link
Contributor

Do we want to make proxy support a part of 1.0?

@tomchristie
Copy link
Member Author

I think we could probably either take it or leave it.

@sethmlarson
Copy link
Contributor

Also I know you've already got mkdocs setup, but what are your thoughts on switching to Sphinx to get code referencing to work? For example currently you can't click on httpx.Client and go to where it's documented.

We can pull all the styling from the current docs into a template so the look and feel will be the same.

@tomchristie
Copy link
Member Author

Personally, I'd prefer not too. Or at least not unless we're streamlining a whole bunch of related projects under python-http. As long as it's something under encode I'd like to see it in-line with how other projects in this org are being managed - that keeps things simple from my POV.

Instead I'd rather get around to adding better interlinking and API docs generation to mkdocs.

@tomchristie
Copy link
Member Author

May well be that my gauge on that evolves as things go, but that'd be where I'm at right now.

@StephenBrown2
Copy link
Contributor

Re: mkdocs, pydoc-markdown handles the auto-generation of mkdocs pages from docstrings. It's not quite as smart as Sphinx in that it doesn't do cross-references well yet, though that's apparently planned for 3.x. I'd love to see it or mkdocs gain support for that.

@florimondmanca
Copy link
Member

Hey, should we make use of milestones to track work left to do for 1.0? And perhaps pin this issue so we can easily find it back/keep focus? :)

Also I think we can tick “Review Auth/retry interface” thanks to middleware?

@tomchristie
Copy link
Member Author

Hey, should we make use of milestones to track work left to do for 1.0?

Probably, yes. There's certainly at the very least a clear distinction between "stuff required for 1.0" and "stuff not stictly required for 1.0", and it'd be good for us to start to narrow in on the target at this point.

@florimondmanca florimondmanca pinned this issue Sep 15, 2019
@florimondmanca florimondmanca added this to the v1.0 milestone Sep 15, 2019
@florimondmanca
Copy link
Member

florimondmanca commented Sep 15, 2019

I went ahead and pinned this issue, as well as marked a bunch of issues (some of them already closed so we don't feel like everything remains to be done 😄) as part of v1.0: https://github.com/encode/httpx/milestone/1. I also edited the issue description with more related issues so we can better see whether we addressed the various points in the near future.

@tomchristie
Copy link
Member Author

Closing this off as gone-stale.

@florimondmanca florimondmanca unpinned this issue Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants