Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable redirects by default for HEAD requests #1183

Conversation

dongskyler
Copy link
Contributor

Fix #1146

This PR sets default allow_redirects to True. It was False before this PR.

This will align our behavior with most other http request libraries, except for Requests.

Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I'll add a test in a follow-up PR. :-)

@florimondmanca florimondmanca merged commit a226c60 into encode:master Aug 16, 2020
@florimondmanca florimondmanca changed the title Fix #1146 Set default allow_redirects to true Enable redirects by default for HEAD requests Aug 16, 2020
@dongskyler
Copy link
Contributor Author

Sounds great.

@dongskyler dongskyler deleted the feature/set-default-allow-redirects-to-true branch August 16, 2020 12:52
j178 added a commit that referenced this pull request Aug 20, 2020
@j178 j178 mentioned this pull request Aug 20, 2020
j178 added a commit that referenced this pull request Aug 20, 2020
j178 added a commit that referenced this pull request Aug 20, 2020
j178 added a commit that referenced this pull request Aug 20, 2020
Co-authored-by: Tom Christie <tom@tomchristie.com>
@tomchristie tomchristie mentioned this pull request Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow_redirects with httpx.head(...)
2 participants