Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor decoder refactoring. #1276

Merged
merged 5 commits into from
Sep 10, 2020
Merged

Minor decoder refactoring. #1276

merged 5 commits into from
Sep 10, 2020
+16 −15

Conversation

tomchristie
Copy link
Member

  • Drop response.decoder property, since we don't actually want to expose the decode API. (Refs Tightening public API on models #1275)
  • Decoder -> ContentDecoder. (Since it's more obviously distinct from TextDecoder, LineDecoder, rather than looking like a base class for all of them, which it isn't.)

@tomchristie tomchristie added the refactor Issues and PRs related to code refactoring label Sep 10, 2020
florimondmanca
florimondmanca approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomchristie tomchristie merged commit 6006721 into master Sep 10, 2020
@tomchristie tomchristie deleted the decoder-refactoring branch September 10, 2020 14:10
@tomchristie tomchristie mentioned this pull request Sep 21, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomchristie @florimondmanca