Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Drop private imports from test_proxies.py #2850

Merged
merged 1 commit into from Sep 16, 2023
Merged

test: Drop private imports from test_proxies.py #2850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/client/test_proxies.py
View file
Open in desktop
Expand Up @@ -2,7 +2,6 @@
import pytest

import httpx
from httpx._utils import URLPattern


def url_to_origin(url: str) -> httpcore.URL:
Expand Down Expand Up @@ -35,11 +34,12 @@ def url_to_origin(url: str) -> httpcore.URL:
)
def test_proxies_parameter(proxies, expected_proxies):
client = httpx.Client(proxies=proxies)
client_patterns = [p.pattern for p in client._mounts.keys()]
client_proxies = list(client._mounts.values())

for proxy_key, url in expected_proxies:
pattern = URLPattern(proxy_key)
assert pattern in client._mounts
proxy = client._mounts[pattern]
assert proxy_key in client_patterns
proxy = client_proxies[client_patterns.index(proxy_key)]
assert isinstance(proxy, httpx.HTTPTransport)
assert isinstance(proxy._pool, httpcore.HTTPProxy)
assert proxy._pool._proxy_url == url_to_origin(url)
Expand Down