Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix 404ing /advanced/#<anchor> links -> /advanced/clients/#<anchor> #3123

Merged

Conversation

nick2i
Copy link
Contributor

@nick2i nick2i commented Feb 28, 2024

Summary

A couple of the documentation links in httpx/_client.py docstrings were out of date and led to 404's:
https://www.python-httpx.org/advanced/#request-instances
https://www.python-httpx.org/advanced/#merging-of-configuration

These have been updated to:

https://www.python-httpx.org/advanced/clients/#request-instances
https://www.python-httpx.org/advanced/clients/#merging-of-configuration

I hope this doesn't require a prior discussion 😄

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@nick2i nick2i marked this pull request as draft February 28, 2024 18:09
Copy link
Member

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ☺️ - is this ready to leave draft?

@nick2i
Copy link
Contributor Author

nick2i commented Feb 28, 2024

Thanks ☺️ - is this ready to leave draft?

Yes, sorry, I noticed a few other similarly broken links and will put up a separate PR

@nick2i nick2i marked this pull request as ready for review February 28, 2024 18:12
@tomchristie tomchristie merged commit 6045186 into encode:master Feb 28, 2024
5 checks passed
shepilov-vladislav pushed a commit to shepilov-vladislav/httpx that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants