Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement order by #70

Merged
merged 12 commits into from
Aug 24, 2021
Merged

Conversation

AndTheDaysGoBy
Copy link
Contributor

Fixed according to the discussion in #26, e.g. generating a new QuerySet via init, and implemented order by. A timestamp was also added the User model in the tests for the sake of variance of types while testing order by.

@AndTheDaysGoBy
Copy link
Contributor Author

Sorry if not proper etiquette with respect to the prior pull request; however, the previous PR had dormant for over a year.

@MightySCollins
Copy link

This PR or the previous one should really be looked into. This is core ORM functionality...
Sadly this project seems quite inactive and other very useful PR's seem abandoned.

@AndTheDaysGoBy
Copy link
Contributor Author

Actually, this issue has returned to my spotlight when I was trying to use or implement something like django-chunkator, but that would require the ability to order_By. If only that was supported, django-chunkator may be able to be used as is, or, if not, easily be ported.

@aminalaee aminalaee mentioned this pull request Aug 20, 2021
@aminalaee aminalaee self-assigned this Aug 21, 2021
orm/models.py Outdated Show resolved Hide resolved
@aminalaee aminalaee merged commit 62433de into encode:master Aug 24, 2021
@aminalaee aminalaee mentioned this pull request Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants