TestClient follow_redirects

[aminalaee]

I think before #1376 the TestClient would not follow redirects,
but it's now set follow_redirects=True by default.

I'm not sure if this was on purpose or by mistake. Other than failing existing tests, now it has a different behaviour compared to httpx because httpx has follow_redirects=False by default.

Here's a sample code to show the difference:

from starlette.applications import Starlette
from starlette.routing import Route
from starlette.responses import PlainTextResponse, RedirectResponse
from starlette.testclient import TestClient
from httpx import AsyncClient


def foo(request):
    return PlainTextResponse("Hello World!")


def bar(request):
    return RedirectResponse(request.url_for("foo"), status_code=302)


app = Starlette(
    routes=[
        Route("/foo", foo),
        Route("/bar", bar),
    ]
)


async def test_async():
    client = AsyncClient(app=app, base_url="http://testserver")
    response = await client.get("/bar")
    assert response.status_code == 302


def test_sync():
    client = TestClient(app)
    response = client.get("/bar")
    assert response.status_code == 200

I found this today as I saw pipelines failing for my project: https://github.com/aminalaee/sqladmin which use both sync and async tests.

[aminalaee]

@Kludex Any ideas?

[Kludex]

I'd appreciate. Thanks Amin 🙏

We should probably confirm this was actually not thought on the PR that introduced it.

[aminalaee]

Yeah sure.

[Kludex]

What was the conclusion here? 🤔

[aminalaee]

I think that we are in a better position than before (?)
#1872 (comment)

[inikolaev]

What was the conclusion after all? I'm running into this issue and what I need is to disable following redirects on TestClient level. I'm fine if this behaviour is enabled by default, but please provide means to configure that. Right now it can only be configured for each individual request.

Something like this would work perfectly:

client = TestClient(follow_redirects=False)

[Kludex]

This was the conclusion: #1872 (comment)

[inikolaev]

Would it be acceptable make that behaviour configurable? Right now I basically had to make a wrapper to make it work for our use-case:

class TestClientWrapper(TestClient):
    """TestClient wrapper with disabled redirects."""

    def _choose_redirect_arg(
        self,
        follow_redirects: Optional[bool],
        allow_redirects: Optional[bool],
    ) -> Union[bool, httpx._client.UseClientDefault]:
        return False