Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware #1

Closed
3 of 7 tasks
tomchristie opened this issue Jun 25, 2018 · 3 comments
Closed
3 of 7 tasks

Middleware #1

tomchristie opened this issue Jun 25, 2018 · 3 comments

Comments

@tomchristie
Copy link
Member

tomchristie commented Jun 25, 2018 •
edited

  • Debug - Return proper debug pages.
  • StaticFiles - Static file serving.
  • Routing - Request routing.
  • Broadcast - Pub/Sub style broadcast.
  • StrictASGI - Ensure ASGI compliance.
  • Proxy - HTTP Proxying.
  • CSRF, CORS, Sessions.
@jordaneremieff
Copy link
Sponsor Contributor

I had previously been refactoring the old uvitools into the new ASGI spec here that could help serve as a reference for some of these. There is also a base middleware implementation here that seems to work well, it based on the middleware in Channels here and the guidelines in the spec here.

@jordaneremieff
Copy link
Sponsor Contributor

May not specifically relate to middleware, but a GINO extension for Starlette may be something to look into: https://github.com/fantix/gino

@jordaneremieff jordaneremieff mentioned this issue Jul 29, 2018
Closed
@tomchristie
Copy link
Member Author

Okay, instead of this catch-all issue, let's take anything we want up in a specific issue/pr.

@akdor1154 akdor1154 mentioned this issue Feb 24, 2020
Closed
@simonw simonw mentioned this issue Mar 1, 2020
Closed
@austincollinpena austincollinpena mentioned this issue Jun 2, 2020
Closed
graingert pushed a commit to graingert/starlette that referenced this issue Jun 11, 2021
@uSpike
Merge pull request encode#1 from graingert/anyio
390b7a1 
fix BaseHTTPMiddleware when used without Starlette
@Niccolum Niccolum mentioned this issue Jan 12, 2022
Closed
2 tasks
Kludex added a commit that referenced this issue Jul 10, 2022
@rednafi @adriangb @Kludex
Explain 'TestClient(app) as client' vs 'client = TestClient(app)' (#1… (
643c3f2 
#1747)

* Explain 'TestClient(app) as client' vs 'client = TestClient(app)' (#1733)

* Nit (#1733)

* Update docs/testclient.md (#1733)

Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>

* Update docs/testclient.md

Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>

* Update docs/testclient.md

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>

* Update docs/testclient.md

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>

Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomchristie @jordaneremieff