Update CI scripts to match httpcore #1043
Conversation
| @@ -12,6 +12,7 @@ ujson | |||
| autoflake | |||
| black==20.8b1 | |||
| databases[sqlite] | |||
| flake8 | |||
There was a problem hiding this comment.
Not doing flake8-bugbear or flake8-pie for now. They're not passing and this PR is big enough already.
|
|
||
| [mypy-tests.*] | ||
| disallow_untyped_defs = False | ||
| # check_untyped_defs = True |
There was a problem hiding this comment.
This doesn't pass yet. Not sure whether to remove or add a TODO comment or something?
There was a problem hiding this comment.
Probably remove this tests.* section and log a ticket to "Add type checking to test suite"?
There was a problem hiding this comment.
I created #1045 (open issue number 100 😰). I think it makes sense to leave mypy-tests.* in here and have mypy run against the tests directory like we do so that it can still check (very basic) things and at least we don't regress.
| @@ -520,20 +520,20 @@ async def lifespan(self, scope: Scope, receive: Receive, send: Send) -> None: | |||
| """ | |||
| first = True | |||
| app = scope.get("app") | |||
| message = await receive() | |||
There was a problem hiding this comment.
Unused variable picked up by flake8.
| @@ -130,7 +130,7 @@ async def app(request): | |||
| @app.route("/dashboard/decorated") | |||
| @async_inject_decorator(additional="payload") | |||
| @requires("authenticated") | |||
| async def decorated_sync(request, additional): | |||
| async def decorated_async(request, additional): | |||
There was a problem hiding this comment.
These two functions were redefinitions which flake8 picked up. I tried to give them better names.
Apologies in advance: this is quite a lot of stuff in not many commits. It was a kind of "copy as much as possible verbatim from httpcore and then make it work" task 😬
Here's a rough summary of all that this changes:
scripts/<>files from httpcore, adjust any existing to matchscripts/publishanymore