-
-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add route-level middleware #1286
Closed
Closed
Changes from 37 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
c2809bd
Add route-level middleware
adriangb 2fb13a6
Remove websocker stuff
adriangb e57a42f
Remove spaces
adriangb 6e4c6dc
remove newline
adriangb ad31857
revert more changes
adriangb fdbdfc0
Merge branch 'master' into route-middleware
adriangb 4549f2c
linting
adriangb b56203c
Merge branch 'master' into route-middleware
adriangb 5c4bb5e
Merge branch 'master' into route-middleware
adriangb 5d0719d
Merge branch 'master' into route-middleware
adriangb fed281b
Merge branch 'master' into route-middleware
adriangb 7a4e991
Merge branch 'master' into route-middleware
adriangb 90e85f4
Merge branch 'master' into route-middleware
adriangb 013bc9e
Merge branch 'master' into route-middleware
adriangb 5ec5871
add Mount middleware and docs
adriangb 3c64e17
add warning about modifying the path
adriangb 586ed21
combine tests
adriangb 24988bf
Update docs/middleware.md
adriangb 73f920c
linting
adriangb e8dcb7f
Merge branch 'master' into route-middleware
adriangb 14f85bd
Add note on error handling
adriangb eb7d41d
capture routes before wrapping
adriangb b78aa8a
Merge branch 'route-middleware' of https://github.com/adriangb/starle…
adriangb 55b44f3
Merge branch 'master' into route-middleware
adriangb e25d88a
Merge branch 'master' into route-middleware
adriangb 93ef0e3
chore: run linting
adriangb 425c079
Merge branch 'master' into route-middleware
adriangb 9783b8f
Merge branch 'master' into route-middleware
adriangb 1f6b230
Merge branch 'master' into route-middleware
adriangb b225269
fix botched merge
adriangb 62c3b61
add test for preservation of behavior of modifying an app after mounting
adriangb c25ac02
lint
adriangb 3562102
Merge branch 'master' into route-middleware
adriangb 284e776
Merge branch 'master' into route-middleware
adriangb 492797c
Merge branch 'master' into route-middleware
adriangb bc6db94
Merge branch 'master' into route-middleware
adriangb 40ddec2
Merge branch 'master' into route-middleware
adriangb e948795
Merge branch 'master' into route-middleware
adriangb 6ec05f2
remove unused variable
adriangb b58f0c3
add comment on why we dynamically fetch routes
adriangb e9ff903
grab routes in __init__ and remove _user_app
adriangb 6589620
Merge branch 'master' into route-middleware
adriangb 47fe966
Merge branch 'master' into route-middleware
adriangb 3b01035
Update starlette/routing.py
adriangb 15b136b
Merge branch 'master' into route-middleware
adriangb 530f8c2
Merge branch 'master' into route-middleware
adriangb 77f50a7
Merge branch 'master' into route-middleware
adriangb 20dbbe5
Merge branch 'master' into route-middleware
adriangb 6120cbc
Merge branch 'master' into route-middleware
adriangb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this variable used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, it is not being used. It's leftover from a previous implementation.